-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of feature references in the sdk #1032
Conversation
c071606
to
644a9f4
Compare
ce2bf64
to
f436273
Compare
allow feat refs for it
f436273
to
8a9c4b6
Compare
There's a number of I haven't dug enough to see if it's even possible (or useful) to try to specify a GeoJSON type (like by applying more type variables to dict keys, though honestly it doesn't feel useful)... But something like this might be a nice compromise (untested in mypy or other static checker)
|
d0eaae6
to
818cf67
Compare
818cf67
to
0b2ce07
Compare
e8372a0
to
b2650c0
Compare
I see this MR includes integration tests for the Data API/CLI, and the Subscriptions CLI. @angaither Do you think we also need tests for the Subscriptions API and Orders API/CLI? |
b2650c0
to
f3bbee9
Compare
We probably only need CLI tests since that is doing a bit more manipulation and allowing strings, so I added a test for the orders CLI.
|
4481acb
to
81c3835
Compare
8502879
to
862d92f
Compare
Related Issue(s):
Closes #
Proposed Changes:
For inclusion in changelog (if applicable):
Not intended for changelog:
Diff of User Interface
Old behavior:
geojson was required to make a subscription or order.
New behavior:
geojson or a geometry feature reference can be used
Or in the cli a ref can be used as a string
PR Checklist:
(Optional) @mentions for Notifications: