-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change search-create name/filter options/parameters to match search UI #883
Conversation
@cholmes FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had time to check out and try things out, but the description of changes looks right on, so as long as this is doing what's described / expected I'm +1.
Hrm, just realized the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great, just a few small, very minor comments.
Co-authored-by: Kevin Lacaille <kevinlacaille@gmail.com>
…ient-python into saved-search-filter
Awesome work, Jen! |
Related Issue(s):
Closes #884
Proposed Changes:
For inclusion in changelog (if applicable):
planet data search-create
andDataClient.create_search()
inline withplanet data search
andDataClient.search()
by moving name and filter to required options in the CLI and rearranging the order of the parameters to(item_types, search_filter, name)
in the Python library.Not intended for changelog:
Diff of User Interface
Old behavior:
planet data search-create name PSScene filter.json
New behavior:
planet data search-create PSScene --filter filter.json --name search_name
PR Checklist:
(Optional) @mentions for Notifications:
There are no docs for these functions so there was nothing to update. #885 addresses adding them.