-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data CLI documentation updates #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address typos (lines 149 & 329)
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Co-authored-by: JuLee Burdekin <91982271+JuLeeAtPlanet@users.noreply.github.com>
Ok, made all the suggested changes. Note the first two were errors in the original file, not in the PR, so in the future it'd be easier if those are just done in a separate review. But went ahead and got them all in. |
Updated for the syntax updates (#884, #887, #890). Note one still has to be merged. I'm not sure exactly how the docs builds work, but we probably don't want to publish this update until the next version is actually released. Note that #890 (Pr #898) is not yet closed, but I documented here anticipating that it would. |
Related Issue(s):
Closes #886, #885, #615
Proposed Changes:
For inclusion in changelog (if applicable):
Not intended for changelog:
NOTE: - The new documentation in this PR will need to be updated when #884 lands, and also if #890 and #887 land. Changes should be simple/easy, but we should be sure to update. I originally started out the docs anticipating #884, but then I wasn't sure if the other two would land, so seemed easiest to just make the docs so they can merge immediately. Then if #884 lands first we can update this PR, and if this lands first we can update that PR.
PR Checklist:
(Optional) @mentions for Notifications: