Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/connect: handle Windows socket error 10013 (WSAEACCES) #270

Merged
merged 1 commit into from
May 24, 2021

Conversation

fatih
Copy link
Member

@fatih fatih commented May 24, 2021

This PR also handles the case when a socket fails to bind to a socket with exclusive access. For more information, check out the docs for the code 10013: https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2

fixes: #265

@fatih fatih requested a review from a team as a code owner May 24, 2021 09:45
This PR makes sure to also handle the case when a socket fails to bind to socket with exclusive access. For more information checkout the docs for the code `10013`: https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2

fixes: #265
Copy link
Member

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fatih fatih merged commit 72e59eb into main May 24, 2021
@fatih fatih deleted the fatih-addr-in-use branch May 24, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants