tty: detect tty without depending on the color package #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue when coloring is disabled with `NO_COLOR` enviroment variable. This would set `color.NoColor` to true and hence in an enviroment where `NO_COLOR` is set, commands like `pscale auth login` would fail: ``` $ pscale auth login Error: The 'login' command requires an interactive shell ``` Now, if the user sets the `NO_COLOR` environment variable, it still continues to work, but only the color's are disabled.
iheanyi
approved these changes
May 24, 2021
mscoutermarsh
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when coloring is disabled with the
NO_COLORenvironment variable. This would setcolor.NoColorvariable totrue, and hence in an environment whereNO_COLORis set, commands likepscale auth loginwould fail:With this change, if the user sets the
NO_COLORenvironment variable, it continues to work, but only the colors are disabled.