connect: exit if --execute finishes
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the behaviour of the `--execute` flag. Previously we would continue to serve the proxy even if the command with `--execute` would finish or fail. With this PR we're changing it. Instead of silently continuing to run, we're exiting completely and shutting down the proxy. I believe this is the correct behaviour given the fact that the user explicitly has passed the `--execute` flag.
iheanyi
approved these changes
May 25, 2021
| ch.Printer.Println("running command with --execute has failed: %s", err) | ||
| } | ||
|
|
||
| // TODO(fatih): is it worth to making cancellation configurable? |
nickvanw
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the
--executeflag.Previously we would continue to serve the proxy even if the command with
--executewould finish or fail. With this PR, we're changing it. Instead of silently continuing to run, we're exiting entirely and shutting down the proxy. This is the correct behavior because the user explicitly has passed the--executeflag, and we should assume they only want to run the proxy for a single command.If there are use cases where we don't want to exit, it's also easy to add it now. We could introduce a new flag that changes whether to call
cancel()or not.