Fixes missing Reset in ResetVT #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash merge if approved ! |
|
Thank you! Merged and fixed the conflicts manually. |
axw
added a commit
to elastic/apm-aggregation
that referenced
this pull request
Aug 30, 2023
Now that planetscale/vtprotobuf#84 is merged, revert to using the upstream project. We should update again when there's a new release.
axw
added a commit
to elastic/apm-aggregation
that referenced
this pull request
Aug 30, 2023
* Revert to planetscale/vtprotobuf Now that planetscale/vtprotobuf#84 is merged, revert to using the upstream project. We should update again when there's a new release. * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Pooling and so ResetVT we definitively want to reuse slices.
However a bug was recently discovered where it would not zeroed slice items.
#35 introduces a fixes by simply removing slice recycling which I think makes pooling a bit less interesting.
This PR rollback #35 and takes another approach that actually Reset the member even if ResetVT is not available because the feature pool is deactivate for that type.
I can't generate anything unfortunately I don't have the protoc version I'd appreciate help for re-generating those.