Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated feature in PHP 7.4 #148

Closed
AyrA opened this issue May 15, 2020 · 1 comment
Closed

Deprecated feature in PHP 7.4 #148

AyrA opened this issue May 15, 2020 · 1 comment

Comments

@AyrA
Copy link

AyrA commented May 15, 2020

Curly braces for indexes are deprecated as of PHP 7.4 (Released 28 Nov 2019): https://wiki.php.net/rfc/deprecate_curly_braces_array_access

Type Exception
Message [String.php:890] Array and string offset access syntax with curly braces is deprecated
Code 0x00002000
Trace lib.php (Line: 694)
Trace TeamSpeak3.php(452) err(integer,string,string,integer,array)
Trace TeamSpeak3.php(452) include_once()
Trace TeamSpeak3.php(507) loadClass(string)
Trace (?) autoload(string)
Trace Uri.php(218) spl_autoload_call(string)
Trace TeamSpeak3.php(322) getScheme()

These braces need replacement with square brackets. A migration script is available: https://gist.github.com/theodorejb/763b83a43522b0fc1755a537663b1863
Sebbo94BY pushed a commit to Sebbo94BY/ts3phpframework that referenced this issue May 17, 2020
planetteamspeak#148: Fixed deprecated curly braces in PHP 7.4
4b3efac
@Sebbo94BY Sebbo94BY mentioned this issue May 17, 2020
Merged
ronindesign pushed a commit that referenced this issue May 18, 2020
@Sebbo94BY @Sensznet
@y4roc @svenpaulsen @Fjonan
Dev (#145)
fa52249 
* Icon Download extended function (#131)

* Update Server.php

Option to Download an icon by name.
This has the benefit that you don't have to change the virtualserver_icon_id to download a specific icon.

* Update Server.php

fixed name was not set for download

* Fixing naming error (#135)

* try to fix issue #136

* add -banners option to channellist

* remove iconname argument

use transferInitDownload() instead

* add -keepfiles argument to snapshot deploy

* update changelog

* set release date for 1.1.34

* Fixing deprecated curly braces for PHP 7.4+ (#142)

* removed deprecated curly braces from string.php, host.php, crypt.php, char.php

* removed another deprecated curly braces from string.php (#144)

overlooked one more curly braces

* * Added Travis CI build status icon to README
* Travis CI tests now also PHP 7.3 and 7.4
* Improved composer.json
* Updated command to run all tests in README
* Added `docker-compose up` to README for existing docker container(s)
* Fixed PHPUnit config issues

* Exposed ServerQuery SSH port

* Switched from libssh to phpseclib

* Changed requirement from PHP extension SSH to phpseclib

* Fixed composer warning

* #148: Fixed deprecated curly braces in PHP 7.4

* Updated composer packages

Co-authored-by: Sensznet <ssensz@gmx.de>
Co-authored-by: Thomas Hanke <18329992+thhan@users.noreply.github.com>
Co-authored-by: Sven Paulsen <info@sven-paulsen.de>
Co-authored-by: Fjonan <fjonan@fjonan.com>
Co-authored-by: Sebastian Krätzig <sebastian.kraetzig@4g-server.eu>
@Sebbo94BY
Copy link
Collaborator

All deprecated curly braces should be replaced with square braces.

@Sebbo94BY Sebbo94BY mentioned this issue Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AyrA @Sebbo94BY