Icon Download extended function #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option to Download an icon by name. This has the benefit that you don't have to change the virtualserver_icon_id to download a specific icon.
fixed name was not set for download
|
Thanks for your contribution! This looks good to me. I'll plan on merging
it after testing.
…On Thu, Nov 7, 2019 at 6:46 AM Sensznet ***@***.***> wrote:
Option to Download an icon by name.
This has the benefit that you don't have to change the
virtualserver_icon_id to download a specific icon.
------------------------------
You can view, comment on, or merge this pull request online at:
#131
Commit Summary
- Update Server.php
- Update Server.php
File Changes
- *M* libraries/TeamSpeak3/Node/Server.php
<https://github.com/planetteamspeak/ts3phpframework/pull/131/files#diff-0>
(16)
Patch Links:
- https://github.com/planetteamspeak/ts3phpframework/pull/131.patch
- https://github.com/planetteamspeak/ts3phpframework/pull/131.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#131?email_source=notifications&email_token=AAKZKAKOB7SIRTF3X5VAT4LQSQS6BA5CNFSM4JKHWX52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HXUCDWQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKZKAM4UMYIDM2CHHUAMG3QSQS6BANCNFSM4JKHWX5Q>
.
|
|
This has been merged, thanks for the contribution! |
ronindesign
added a commit
that referenced
this pull request
Nov 27, 2019
Merged
ronindesign
pushed a commit
that referenced
this pull request
Nov 27, 2019
* Update project to PSR-4 * Rename exceptions and copy duplicated functions for group in parent class * Rename exceptions and copy duplicated functions for group in parent class * start mockup ServerQuery * Icon Download extended function (#131) * Update Server.php Option to Download an icon by name. This has the benefit that you don't have to change the virtualserver_icon_id to download a specific icon. * Update Server.php fixed name was not set for download
ronindesign
pushed a commit
that referenced
this pull request
May 18, 2020
* Icon Download extended function (#131) * Update Server.php Option to Download an icon by name. This has the benefit that you don't have to change the virtualserver_icon_id to download a specific icon. * Update Server.php fixed name was not set for download * Fixing naming error (#135) * try to fix issue #136 * add -banners option to channellist * remove iconname argument use transferInitDownload() instead * add -keepfiles argument to snapshot deploy * update changelog * set release date for 1.1.34 * Fixing deprecated curly braces for PHP 7.4+ (#142) * removed deprecated curly braces from string.php, host.php, crypt.php, char.php * removed another deprecated curly braces from string.php (#144) overlooked one more curly braces * * Added Travis CI build status icon to README * Travis CI tests now also PHP 7.3 and 7.4 * Improved composer.json * Updated command to run all tests in README * Added `docker-compose up` to README for existing docker container(s) * Fixed PHPUnit config issues * Exposed ServerQuery SSH port * Switched from libssh to phpseclib * Changed requirement from PHP extension SSH to phpseclib * Fixed composer warning * #148: Fixed deprecated curly braces in PHP 7.4 * Updated composer packages Co-authored-by: Sensznet <ssensz@gmx.de> Co-authored-by: Thomas Hanke <18329992+thhan@users.noreply.github.com> Co-authored-by: Sven Paulsen <info@sven-paulsen.de> Co-authored-by: Fjonan <fjonan@fjonan.com> Co-authored-by: Sebastian Krätzig <sebastian.kraetzig@4g-server.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to Download an icon by name.
This has the benefit that you don't have to change the virtualserver_icon_id to download a specific icon.