Add docs to Diffing.swift #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessesquires I added |
|
How do I re-gen docs? |
Generated by 🚫 Danger |
|
we should wait on the docs until we're ready to tag and release the next release, since the changes will go live immediately |
|
seems like that's the plan for 0.3, so 👌 |
|
Ah gotcha. Usually do it post release? |
|
@jessesquires good to approve this one then? |
I like to gen docs once everything is ready for the release, commit that, then tag the release immediately after. Feels cleaner that way, bundles everything up nicely.
my bad! thought i accepted. |
jessesquires
approved these changes
Sep 20, 2018
|
Ah gotcha. Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #143
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.