Refactored inline boundry check (no projects) to a before_filter.

app/controllers/bulk_time_entries_controller.rb

@@ -5,6 +5,7 @@ class BulkTimeEntriesController < ApplicationController
   before_filter :load_activities
   before_filter :load_allowed_projects
   before_filter :load_first_project
+  before_filter :check_for_no_projects
 
   helper :custom_fields
   include BulkTimeEntriesHelper
@@ -13,10 +14,6 @@ class BulkTimeEntriesController < ApplicationController
 
   def index
     @time_entries = [TimeEntry.new(:spent_on => Date.today.to_s)]
-
-    if @projects.empty?
-      render :action => 'no_projects'
-    end
   end
 
   def load_assigned_issues
@@ -84,6 +81,13 @@ def load_first_project
     @first_project = @projects.sort_by(&:lft).first unless @projects.empty?
   end
 
+  def check_for_no_projects
+    if @projects.empty?
+      render :action => 'no_projects'
+      return false
+    end
+  end
+
   def self.allowed_project?(project_id)
     return User.current.projects.find_by_id(project_id, :conditions => Project.allowed_to_condition(User.current, :log_time))
   end

test/functional/bulk_time_entries_controller_test.rb

@@ -11,6 +11,7 @@ class BulkTimeEntriesControllerTest < ActionController::TestCase
   should_have_before_filter :load_activities
   should_have_before_filter :load_allowed_projects
   should_have_before_filter :load_first_project
+  should_have_before_filter :check_for_no_projects
 
   context "GET to :index" do
     context "as a user without any projects" do
@@ -22,7 +23,7 @@ class BulkTimeEntriesControllerTest < ActionController::TestCase
       end
 
       should_respond_with :success
-      should_assign_to :time_entries
+      should_not_assign_to :time_entries
       should_assign_to :projects
       should_render_template :no_projects