Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show / enforce required fields #71

Closed
m-triassi opened this issue Mar 11, 2022 · 0 comments · Fixed by #72
Closed

Show / enforce required fields #71

m-triassi opened this issue Mar 11, 2022 · 0 comments · Fixed by #72
Assignees
@m-triassi
Labels
bug Something isn't working

Comments

@m-triassi
Copy link
Contributor

m-triassi commented Mar 11, 2022 •
edited

Describe the bug

When updating media, a 500 error is thrown if required fields are passed as null.

To Reproduce

Steps to reproduce the behavior:

  1. Visit the media manager
  2. Click on a piece of media to get its details
  3. Leave a required field blank
  4. Save the media
  5. See that nothing happens.

Expected behavior

There should be a warning that tells the user they've omitted a required field

Additional context

We're essentially missing proper request validation and error passing to make this work right.
@m-triassi m-triassi added the bug Something isn't working label Mar 11, 2022
@m-triassi m-triassi self-assigned this Mar 11, 2022
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
refactor: #71 extract validation from inline controller to request class
c0ec598
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
feat: #71 add toast for validation failures
636b3b5
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
docs: #71 add warning to readme about public usage of this package...
a40610f
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
chore: #71 compile assets to include validation toast
8b20a44
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
fix: #71 adjust validation rules to only expect values if path isnt p…
ef8e3bc 
…resent
m-triassi added a commit that referenced this issue Mar 11, 2022
@m-triassi
fix: #71 avoid filling model with new data if a update wasnt called
e095ed4
@m-triassi m-triassi mentioned this issue Mar 11, 2022
Merged
m-triassi added a commit that referenced this issue Mar 14, 2022
@m-triassi
chore: #71 merge main into 71-field-validation, resolve conflicts
622f5dd
m-triassi added a commit that referenced this issue Mar 14, 2022
@m-triassi
chore: #71 merge master into 71-field-validation, resolve conflicts
39ec26f
@forecast forecast bot mentioned this issue Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-triassi m-triassi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Media update field validation plank/laravel-media-manager
1 participant
@m-triassi