Merge pull request #218 from plank/fix-delete-offset

Fix collection offset access in MediableCollection::delete()
plank · Oct 22, 2020 · 73b8eaf · 73b8eaf
2 parents 1fa77f2 + 369fbb1
commit 73b8eaf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/MediableCollection.php b/src/MediableCollection.php
@@ -114,7 +114,7 @@ public function delete(): void
         /** @var MorphToMany $relation */
         $relation = $this->first()->media();
         $query = $relation->newPivotStatement();
-        $classes = collect();
+        $classes = [];
 
         $this->each(function (Model $item) use ($query, $relation, $classes) {
             // collect list of ids of each class in case not all
@@ -132,7 +132,7 @@ public function delete(): void
         $query->delete();
 
         // delete each item by class
-        $classes->each(function (array $ids, string $class) {
+        collect($classes)->each(function (array $ids, string $class) {
             $class::whereIn((new $class)->getKeyName(), $ids)->delete();
         });
     }