feat: Use environment variables for default admin configuration

plankanban · Sep 11, 2023 · 91bc889 · 91bc889
1 parent a34d8e9
commit 91bc889
Show file tree

Hide file tree

Showing 20 changed files with 224 additions and 121 deletions.
diff --git a/client/src/components/UserInformationEdit/UserInformationEdit.jsx b/client/src/components/UserInformationEdit/UserInformationEdit.jsx
@@ -1,4 +1,5 @@
 import { dequal } from 'dequal';
+import omit from 'lodash/omit';
 import pickBy from 'lodash/pickBy';
 import React, { useCallback, useMemo, useRef } from 'react';
 import PropTypes from 'prop-types';
@@ -9,7 +10,7 @@ import { useForm } from '../../hooks';
 
 import styles from './UserInformationEdit.module.scss';
 
-const UserInformationEdit = React.memo(({ defaultData, onUpdate }) => {
+const UserInformationEdit = React.memo(({ defaultData, isNameEditable, onUpdate }) => {
   const [t] = useTranslation();
 
   const [data, handleFieldChange] = useForm(() => ({
@@ -32,13 +33,17 @@ const UserInformationEdit = React.memo(({ defaultData, onUpdate }) => {
   const nameField = useRef(null);
 
   const handleSubmit = useCallback(() => {
-    if (!cleanData.name) {
-      nameField.current.select();
-      return;
-    }
+    if (isNameEditable) {
+      if (!cleanData.name) {
+        nameField.current.select();
+        return;
+      }
 
-    onUpdate(cleanData);
-  }, [onUpdate, cleanData]);
+      onUpdate(cleanData);
+    } else {
+      onUpdate(omit(cleanData, 'name'));
+    }
+  }, [isNameEditable, onUpdate, cleanData]);
 
   return (
     <Form onSubmit={handleSubmit}>
@@ -48,6 +53,7 @@ const UserInformationEdit = React.memo(({ defaultData, onUpdate }) => {
         ref={nameField}
         name="name"
         value={data.name}
+        disabled={!isNameEditable}
         className={styles.field}
         onChange={handleFieldChange}
       />
@@ -74,6 +80,7 @@ const UserInformationEdit = React.memo(({ defaultData, onUpdate }) => {
 
 UserInformationEdit.propTypes = {
   defaultData: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
+  isNameEditable: PropTypes.bool.isRequired,
   onUpdate: PropTypes.func.isRequired,
 };
 

diff --git a/client/src/components/UserInformationEditStep.jsx b/client/src/components/UserInformationEditStep.jsx
@@ -5,33 +5,40 @@ import { Popup } from '../lib/custom-ui';
 
 import UserInformationEdit from './UserInformationEdit';
 
-const UserInformationEditStep = React.memo(({ defaultData, onUpdate, onBack, onClose }) => {
-  const [t] = useTranslation();
+const UserInformationEditStep = React.memo(
+  ({ defaultData, isNameEditable, onUpdate, onBack, onClose }) => {
+    const [t] = useTranslation();
 
-  const handleUpdate = useCallback(
-    (data) => {
-      onUpdate(data);
-      onClose();
-    },
-    [onUpdate, onClose],
-  );
+    const handleUpdate = useCallback(
+      (data) => {
+        onUpdate(data);
+        onClose();
+      },
+      [onUpdate, onClose],
+    );
 
-  return (
-    <>
-      <Popup.Header onBack={onBack}>
-        {t('common.editInformation', {
-          context: 'title',
-        })}
-      </Popup.Header>
-      <Popup.Content>
-        <UserInformationEdit defaultData={defaultData} onUpdate={handleUpdate} />
-      </Popup.Content>
-    </>
-  );
-});
+    return (
+      <>
+        <Popup.Header onBack={onBack}>
+          {t('common.editInformation', {
+            context: 'title',
+          })}
+        </Popup.Header>
+        <Popup.Content>
+          <UserInformationEdit
+            defaultData={defaultData}
+            isNameEditable={isNameEditable}
+            onUpdate={handleUpdate}
+          />
+        </Popup.Content>
+      </>
+    );
+  },
+);
 
 UserInformationEditStep.propTypes = {
   defaultData: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
+  isNameEditable: PropTypes.bool.isRequired,
   onUpdate: PropTypes.func.isRequired,
   onBack: PropTypes.func,
   onClose: PropTypes.func.isRequired,

diff --git a/client/src/components/UserSettingsModal/AccountPane/AccountPane.jsx b/client/src/components/UserSettingsModal/AccountPane/AccountPane.jsx
@@ -23,6 +23,7 @@ const AccountPane = React.memo(
     phone,
     organization,
     language,
+    isLocked,
     isAvatarUpdating,
     usernameUpdateForm,
     emailUpdateForm,
@@ -74,6 +75,7 @@ const AccountPane = React.memo(
             phone,
             organization,
           }}
+          isNameEditable={!isLocked}
           onUpdate={onUpdate}
         />
         <Divider horizontal section>
@@ -102,63 +104,67 @@ const AccountPane = React.memo(
           value={language || 'auto'}
           onChange={handleLanguageChange}
         />
-        <Divider horizontal section>
-          <Header as="h4">
-            {t('common.authentication', {
-              context: 'title',
-            })}
-          </Header>
-        </Divider>
-        <div className={styles.action}>
-          <UserUsernameEditPopup
-            usePasswordConfirmation
-            defaultData={usernameUpdateForm.data}
-            username={username}
-            isSubmitting={usernameUpdateForm.isSubmitting}
-            error={usernameUpdateForm.error}
-            onUpdate={onUsernameUpdate}
-            onMessageDismiss={onUsernameUpdateMessageDismiss}
-          >
-            <Button className={styles.actionButton}>
-              {t('action.editUsername', {
-                context: 'title',
-              })}
-            </Button>
-          </UserUsernameEditPopup>
-        </div>
-        <div className={styles.action}>
-          <UserEmailEditPopup
-            usePasswordConfirmation
-            defaultData={emailUpdateForm.data}
-            email={email}
-            isSubmitting={emailUpdateForm.isSubmitting}
-            error={emailUpdateForm.error}
-            onUpdate={onEmailUpdate}
-            onMessageDismiss={onEmailUpdateMessageDismiss}
-          >
-            <Button className={styles.actionButton}>
-              {t('action.editEmail', {
-                context: 'title',
-              })}
-            </Button>
-          </UserEmailEditPopup>
-        </div>
-        <div className={styles.action}>
-          <UserPasswordEditPopup
-            usePasswordConfirmation
-            defaultData={passwordUpdateForm.data}
-            isSubmitting={passwordUpdateForm.isSubmitting}
-            error={passwordUpdateForm.error}
-            onUpdate={onPasswordUpdate}
-            onMessageDismiss={onPasswordUpdateMessageDismiss}
-          >
-            <Button className={styles.actionButton}>
-              {t('action.editPassword', {
-                context: 'title',
-              })}
-            </Button>
-          </UserPasswordEditPopup>
-        </div>
+        {!isLocked && (
+          <>
+            <Divider horizontal section>
+              <Header as="h4">
+                {t('common.authentication', {
+                  context: 'title',
+                })}
+              </Header>
+            </Divider>
+            <div className={styles.action}>
+              <UserUsernameEditPopup
+                usePasswordConfirmation
+                defaultData={usernameUpdateForm.data}
+                username={username}
+                isSubmitting={usernameUpdateForm.isSubmitting}
+                error={usernameUpdateForm.error}
+                onUpdate={onUsernameUpdate}
+                onMessageDismiss={onUsernameUpdateMessageDismiss}
+              >
+                <Button className={styles.actionButton}>
+                  {t('action.editUsername', {
+                    context: 'title',
+                  })}
+                </Button>
+              </UserUsernameEditPopup>
+            </div>
+            <div className={styles.action}>
+              <UserEmailEditPopup
+                usePasswordConfirmation
+                defaultData={emailUpdateForm.data}
+                email={email}
+                isSubmitting={emailUpdateForm.isSubmitting}
+                error={emailUpdateForm.error}
+                onUpdate={onEmailUpdate}
+                onMessageDismiss={onEmailUpdateMessageDismiss}
+              >
+                <Button className={styles.actionButton}>
+                  {t('action.editEmail', {
+                    context: 'title',
+                  })}
+                </Button>
+              </UserEmailEditPopup>
+            </div>
+            <div className={styles.action}>
+              <UserPasswordEditPopup
+                usePasswordConfirmation
+                defaultData={passwordUpdateForm.data}
+                isSubmitting={passwordUpdateForm.isSubmitting}
+                error={passwordUpdateForm.error}
+                onUpdate={onPasswordUpdate}
+                onMessageDismiss={onPasswordUpdateMessageDismiss}
+              >
+                <Button className={styles.actionButton}>
+                  {t('action.editPassword', {
+                    context: 'title',
+                  })}
+                </Button>
+              </UserPasswordEditPopup>
+            </div>
+          </>
+        )}
       </Tab.Pane>
     );
   },
@@ -172,6 +178,7 @@ AccountPane.propTypes = {
   phone: PropTypes.string,
   organization: PropTypes.string,
   language: PropTypes.string,
+  isLocked: PropTypes.bool.isRequired,
   isAvatarUpdating: PropTypes.bool.isRequired,
   /* eslint-disable react/forbid-prop-types */
   usernameUpdateForm: PropTypes.object.isRequired,

diff --git a/client/src/components/UserSettingsModal/UserSettingsModal.jsx b/client/src/components/UserSettingsModal/UserSettingsModal.jsx
@@ -16,6 +16,7 @@ const UserSettingsModal = React.memo(
     phone,
     organization,
     language,
+    isLocked,
     subscribeToOwnCards,
     isAvatarUpdating,
     usernameUpdateForm,
@@ -48,6 +49,7 @@ const UserSettingsModal = React.memo(
             phone={phone}
             organization={organization}
             language={language}
+            isLocked={isLocked}
             isAvatarUpdating={isAvatarUpdating}
             usernameUpdateForm={usernameUpdateForm}
             emailUpdateForm={emailUpdateForm}
@@ -104,6 +106,7 @@ UserSettingsModal.propTypes = {
   phone: PropTypes.string,
   organization: PropTypes.string,
   language: PropTypes.string,
+  isLocked: PropTypes.bool.isRequired,
   subscribeToOwnCards: PropTypes.bool.isRequired,
   isAvatarUpdating: PropTypes.bool.isRequired,
   /* eslint-disable react/forbid-prop-types */

diff --git a/client/src/components/UsersModal/Item/ActionsStep.jsx b/client/src/components/UsersModal/Item/ActionsStep.jsx
@@ -64,6 +64,7 @@ const ActionsStep = React.memo(
           return (
             <UserInformationEditStep
               defaultData={pick(user, ['name', 'phone', 'organization'])}
+              isNameEditable={!user.isLocked}
               onUpdate={onUpdate}
               onBack={handleBack}
               onClose={onClose}
@@ -135,26 +136,30 @@ const ActionsStep = React.memo(
                 context: 'title',
               })}
             </Menu.Item>
-            <Menu.Item className={styles.menuItem} onClick={handleEditUsernameClick}>
-              {t('action.editUsername', {
-                context: 'title',
-              })}
-            </Menu.Item>
-            <Menu.Item className={styles.menuItem} onClick={handleEditEmailClick}>
-              {t('action.editEmail', {
-                context: 'title',
-              })}
-            </Menu.Item>
-            <Menu.Item className={styles.menuItem} onClick={handleEditPasswordClick}>
-              {t('action.editPassword', {
-                context: 'title',
-              })}
-            </Menu.Item>
-            <Menu.Item className={styles.menuItem} onClick={handleDeleteClick}>
-              {t('action.deleteUser', {
-                context: 'title',
-              })}
-            </Menu.Item>
+            {!user.isLocked && (
+              <>
+                <Menu.Item className={styles.menuItem} onClick={handleEditUsernameClick}>
+                  {t('action.editUsername', {
+                    context: 'title',
+                  })}
+                </Menu.Item>
+                <Menu.Item className={styles.menuItem} onClick={handleEditEmailClick}>
+                  {t('action.editEmail', {
+                    context: 'title',
+                  })}
+                </Menu.Item>
+                <Menu.Item className={styles.menuItem} onClick={handleEditPasswordClick}>
+                  {t('action.editPassword', {
+                    context: 'title',
+                  })}
+                </Menu.Item>
+                <Menu.Item className={styles.menuItem} onClick={handleDeleteClick}>
+                  {t('action.deleteUser', {
+                    context: 'title',
+                  })}
+                </Menu.Item>
+              </>
+            )}
           </Menu>
         </Popup.Content>
       </>

diff --git a/client/src/components/UsersModal/Item/Item.jsx b/client/src/components/UsersModal/Item/Item.jsx
@@ -17,6 +17,7 @@ const Item = React.memo(
     organization,
     phone,
     isAdmin,
+    isLocked,
     emailUpdateForm,
     passwordUpdateForm,
     usernameUpdateForm,
@@ -46,7 +47,7 @@ const Item = React.memo(
         <Table.Cell>{username || '-'}</Table.Cell>
         <Table.Cell>{email}</Table.Cell>
         <Table.Cell>
-          <Radio toggle checked={isAdmin} onChange={handleIsAdminChange} />
+          <Radio toggle checked={isAdmin} disabled={isLocked} onChange={handleIsAdminChange} />
         </Table.Cell>
         <Table.Cell textAlign="right">
           <ActionsPopup
@@ -57,6 +58,7 @@ const Item = React.memo(
               organization,
               phone,
               isAdmin,
+              isLocked,
               emailUpdateForm,
               passwordUpdateForm,
               usernameUpdateForm,
@@ -88,6 +90,7 @@ Item.propTypes = {
   organization: PropTypes.string,
   phone: PropTypes.string,
   isAdmin: PropTypes.bool.isRequired,
+  isLocked: PropTypes.bool.isRequired,
   /* eslint-disable react/forbid-prop-types */
   emailUpdateForm: PropTypes.object.isRequired,
   passwordUpdateForm: PropTypes.object.isRequired,

diff --git a/client/src/components/UsersModal/UsersModal.jsx b/client/src/components/UsersModal/UsersModal.jsx
@@ -110,6 +110,7 @@ const UsersModal = React.memo(
                   organization={item.organization}
                   phone={item.phone}
                   isAdmin={item.isAdmin}
+                  isLocked={item.isLocked}
                   emailUpdateForm={item.emailUpdateForm}
                   passwordUpdateForm={item.passwordUpdateForm}
                   usernameUpdateForm={item.usernameUpdateForm}