-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JLatexMath support in Docker image #116
Comments
the documentation says the jar files are large, so they need to be downloaded seperated and put into the same folder as plantuml.jar file. So I'm thinking maybe you can download the jar files and mount them to the right folder. |
The image has a size of over 400MB, I think the 3.7MB of the JLatexMath extension shouldn't be any problem. I can't find any plantuml.jar in the Docker image, therefore I don't know where I should mount the JLatexMath files. Any ideas? |
Sorry, I just read the instructions, don't know what to do with it. |
If I remeber correctly, I already tried this without success. :-( |
I believe the instructions you are referring to are for a standalone setup. For docker setup it is packaged as war and deployed into jetty/tomcat. We can either add JLatex libs as dependencies to pom.xml or keeps them in WEB-INT/lib and build the docker image. Not sure if any other easy options available. |
Hi @tphani, does this mean that extracting the JLatexMath files into
So there must be another place for copying the files? |
Sorry, if I was not clear. As plant uml is running inside Jetty as a webapp (war file), there is no way of copying the jars into it. We need to build the war with the dependent jars and for that the docker file needs to be modified accordingly. I will try to do this and share in couple of days. |
Alright, thanks. I'm a total noob with this whole Jetty stuff. If you need any help for testing let me know. 😃 |
As we cannot add the libs directly to Jetty, I have added them as dependencies to
Now build the docker image: And run it: This works well for me, not sure if there is any simple way of doing it. Thanks! |
Hi @tphani, I just tested it, and it works perfectly. I will create a PR and hope that the changes are finding its way into the repo very soon. |
I would love to have this feature. Any progress on merging this? |
Sorry it took so long, but I managed to get the alternate way of copying the jar files into the container working fine. Till the changes make it to the official repo, we can do this:
We will loose the changes if we remove the container, but we can run latest version of puml without building it. |
And for the jetty image, use |
The Jetty Docker image does not support JLatexMath and therefore the tags are not working.
Would it be possible to add JLatexMath support? I'm no Java expert, but I can help with the Dockerfile. I just have to know where the JAR files from the Zip archive needs to be placed.
The text was updated successfully, but these errors were encountered: