Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] Allow style for backward element on repeat loop, on Activity diagram #1531

Closed
The-Lum opened this issue Sep 6, 2023 · 5 comments
Closed
Labels

Comments

@The-Lum
Copy link
Collaborator

The-Lum commented Sep 6, 2023

Hi PlantUML team,

Context

To continue (style on (beta-)Activity diagram):

Ref. or other similar issue:

Wanted feature

  • Could you allow style for backward element on Activity diagram?

Source

@startuml
<style>
.save {
  LineColor blue
  BackgroundColor lightCyan
  LineThickness 2
  ArrowThickness 0.5
  FontName Arial Narrow
  FontColor red
  FontSize 11
  FontStyle regular
}
</style>
repeat
  :Generate diagrams; <<save>>
backward:Log context; <<save>>
repeat while (more data?) is (yes)

repeat
  :Generate diagrams; <<save>>
backward:Log
context; <<save>>
repeat while (more data?) is (yes)
@enduml

Output: The backward element is not styled (tested on 1.2023.11beta2)

Regards,
Th.

@github-actions github-actions bot added the triage label Sep 6, 2023
arnaudroques added a commit that referenced this issue Sep 11, 2023
@arnaudroques
Copy link
Contributor

Thanks for the report and for your tests!
This should be fixed in last snapshot.

@LolaBeckett
Copy link

LolaBeckett commented Oct 4, 2023

Nice to get this fix, thank you.
Then I am wondering what is the "backward" skinparam to get one SDL Output shape red and one other green for example.
I did not get "activityshape" to work

@startuml
<style>
.output {
  BackgroundColor red
}

.sdloutputgreen {
  activityshape outputstype
  BackgroundColor lightgreen
}

</style>
repeat
  :Generate diagrams; <<save>>
backward:It is red; <<output>>
repeat while (more data?) is (yes)
repeat
  :Generate diagrams; <<save>>
backward:I want it green and with SDL Output shape; <<sdloutputgreen>>
repeat while (more data?) is (yes)
@enduml

image

@The-Lum
Copy link
Collaborator Author

The-Lum commented Oct 5, 2023

Hi @LolaBeckett,

For that see issues (and wanted features) here:

Awaiting enhancement of those topics,
Regards,
Th.

@gwendalrobic
Copy link

Hi,
Thanks a lot for the functionality to apply the style to a backward element. However, after downloading version 1.2023.12, I cannot style a backward element in a while loop.

@startuml
<style>
.USR {
  BackgroundColor #PowderBlue
}

.SSTEM {
  BackgroundColor #LightGray
}

</style>
while (data available?)
  :read data; <<USR>>
  :generate diagrams;<<SSTEM>>
backward:Collect errors; <<USR>>
endwhile
end
@enduml

I tried this plantuml code on the diagram generator and it ended up like this :

RO_1IiSm3CRlUOg05xtC-rRcc8WN1N7w0DaQkcAsGjevXlZkjaFuN_wN4F9zoIzV5nDfsXO14zCXt4BrERpZ3o3sD7qv3Tjg7uC4nPkti5lMNZQ6Nu1g63wUNgyxNxoRqxFIKOpc_l_oFdjXlBMK2EcRlD0e_707YBKoMIn2WyRa1zgsJ1slh9GOhIUdjCJ6c9EQvJ4pTr9RPwJmb91

In that case, I was expecting the backward element to be colored in PowderBlue.

Should I open a new issue/feature or is it related to that feature ?
Thanks for your consideration.

@The-Lum The-Lum changed the title [Style] Allow style for backward element on Activity diagram [Style] Allow style for backward element on repeat loop, on Activity diagram Dec 20, 2023
@The-Lum
Copy link
Collaborator Author

The-Lum commented Dec 20, 2023

Hi @gwendalrobic, and all,

Thanks for your report.
I just opened a new issue for that: #1632.

Regards,
Th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants