Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with the format of images (now it is CV_32F) #8

Merged
merged 1 commit into from
Apr 6, 2015

Conversation

nlyubova
Copy link

@nlyubova nlyubova commented Apr 1, 2015

No description provided.

@vrabaud
Copy link
Member

vrabaud commented Apr 1, 2015

but if the condition passes, the output has the type of the input, hence an inconsistence.

@nlyubova
Copy link
Author

nlyubova commented Apr 2, 2015

If condition passes than there already was exactly the same conversion,
Thus it gives 32F for both cases now (before this line was just missing)
On Apr 1, 2015 11:05 PM, "Vincent Rabaud" notifications@github.com wrote:

but if the condition passes, the output has the type of the input, hence
an inconsistence.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@vrabaud
Copy link
Member

vrabaud commented Apr 6, 2015

I missed that depth is always CV_32F, thx.

vrabaud added a commit that referenced this pull request Apr 6, 2015
Fixed issue with the format of images (now it is CV_32F)
@vrabaud vrabaud merged commit 418ae10 into plasmodic:master Apr 6, 2015
@nlyubova
Copy link
Author

Vincent,
I've just noticed that you have merged the ecto_image_pipeline but you have
not merged the Linemod. But the commit in ecto_image_pipeline does not work
without the commit in the Linemod. Could you please accept the pull request
for the Linemod?

On Mon, Apr 6, 2015 at 6:58 PM, Vincent Rabaud notifications@github.com
wrote:

Merged #8 #8.


Reply to this email directly or view it on GitHub
#8 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants