Update password length validation to 72 characters max #3319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCrypt has a limit of 72 characters for the password. Anything beyond 72 characters is truncated:
This commit updates the validation to limit passwords to less than 72 characters, keeping within the limitation.
For similar discussion, please see rails/rails#14591 and rails/rails#15708 where
has_secure_password
's validations were updated for this same reason.I should note that I didn't make the change in
lib/devise.rb
, as I thought that would introduce a backwards-incompatible change.