fix(Generator): Dynamically set ActiveRecord class #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 5 models inherit from ApplicationRecord rather than ActiveRecord::Base as in previous versions. This checks the Rails::VERSION::MAJOR and sets the class accordingly in the generator. Tested it manually, couldn't think of an obvious way to write spec coverage. Happy to take direction and add some tests if you have ideas.
monkeyci
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - shoul...
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/AlignArray has the wrong namespace - should be Layout .rubocop.yml: Style/BlockEndNewline has the wrong namespace - should be Layout .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout .rubocop.yml: Style/EndOfLine has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout .rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineBlockLayout has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterMethodName has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterNot has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComment has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideRangeLiteral has the wrong namespace - should be Layout .rubocop.yml: Style/Tab has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout .rubocop.yml: Lint/Eval has the wrong namespace - should be Security Error: The `Style/MethodCallParentheses` cop has been renamed to `Style/MethodCallWithoutArgsParentheses`. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter IndentWhenRelativeTo (for Layout/CaseIndentation) found in .rubocop.yml `IndentWhenRelativeTo` has been renamed to `EnforcedStyle` obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml `AlignWith` has been renamed to `EnforcedStyleAlignWith` obsolete parameter AlignWith (for Lint/DefEndAlignment) found in .rubocop.yml
Rails 5 models inherit from ApplicationRecord rather than ActiveRecord::Base as in previous versions. This checks the Rails::VERSION::MAJOR and sets the class accordingly in the generator. Tested it manually, couldn't think of an obvious way to write spec coverage. Happy to take direction and add some tests if you have ideas.
monkeyci
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - shoul...
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/AlignArray has the wrong namespace - should be Layout .rubocop.yml: Style/BlockEndNewline has the wrong namespace - should be Layout .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout .rubocop.yml: Style/EndOfLine has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout .rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineBlockLayout has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterMethodName has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterNot has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComment has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideRangeLiteral has the wrong namespace - should be Layout .rubocop.yml: Style/Tab has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout .rubocop.yml: Lint/Eval has the wrong namespace - should be Security Error: The `Style/MethodCallParentheses` cop has been renamed to `Style/MethodCallWithoutArgsParentheses`. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter IndentWhenRelativeTo (for Layout/CaseIndentation) found in .rubocop.yml `IndentWhenRelativeTo` has been renamed to `EnforcedStyle` obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml `AlignWith` has been renamed to `EnforcedStyleAlignWith` obsolete parameter AlignWith (for Lint/DefEndAlignment) found in .rubocop.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10.
Rails 5 models inherit from ApplicationRecord rather than ActiveRecord::Base as
in previous versions. This checks the Rails::VERSION::MAJOR and sets the class
accordingly in the generator.
Tested it manually, couldn't think of an obvious way to write spec coverage.
Happy to take direction and add some tests if you have ideas.