Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: opening a dropdown via click event does not close already open dropdowns #178

Closed
greatislander opened this issue Jan 21, 2020 · 0 comments · Fixed by #182
Closed

Menu: opening a dropdown via click event does not close already open dropdowns #178

greatislander opened this issue Jan 21, 2020 · 0 comments · Fixed by #182
Assignees
@greatislander
Labels
bug Something isn't working
Milestone
1.0.0-alpha.8

Comments

@greatislander
Copy link
Collaborator

Describe the bug

If a dropdown is open on desktop, opening another dropdown with the mouse (by clicking its button) should close the other dropdown. It does not currently do so.

To Reproduce

  1. Visit the menus component.
  2. Open a dropdown.
  3. Open another dropdown with the mouse.

Expected behavior

The first dropdown should close as the second opens. Instead, it remains open.

Screenshots

Multiple dropdowns expanded.

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox
  • Version: 72.0.1

Additional context

Not applicable.
@greatislander greatislander added the bug Something isn't working label Jan 21, 2020
@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 21, 2020
@greatislander greatislander self-assigned this Jan 21, 2020
greatislander pushed a commit that referenced this issue Jan 22, 2020
fix: collapse other dropdowns on dropdown toggle open
c3baf5e 
Resolves #178.
@greatislander greatislander mentioned this issue Jan 22, 2020
Merged
2 tasks
greatislander added a commit that referenced this issue Jan 23, 2020
@greatislander
feat: add search bar to menu (resolves #178) (#182)
47e5b72 
* feat: add search component to menu [WIP]
* feat: add responsive search bar to menu
* fix: dismiss search bar on escape, apply home variant styles
* fix: collapse other dropdowns on dropdown toggle open
* fix: remove search bar from home menu
* fix: button aspect ratio
* fix: hide search from home
* fix: search labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-alpha.8
Development

Successfully merging a pull request may close this issue.

feat: add search bar to menu (resolves #178) platform-coop-toolkit/pinecone
1 participant
@greatislander