Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing between borderless buttons #222

Closed
cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Closed

Spacing between borderless buttons #222

cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Labels
enhancement New feature or request

Comments

@cherylhjli
Copy link

Is your feature request related to a problem? Please describe.

Currently the borders are running into each other

Describe the solution you'd like

Space 8px between each borderless button (counting the focus state), like so:
Screen Shot 2020-01-31 at 2 01 43 PM
(bottom is what it would look like spaced out, top is what it would look like without focus)
Please then also make the space between the CTA above and the borderless buttons below 20px.
@cherylhjli cherylhjli added the enhancement New feature or request label Jan 31, 2020
greatislander added a commit that referenced this issue Feb 3, 2020
@greatislander
fix: adjust borderless button spacing (resolve #222)
bbeb600
@greatislander greatislander mentioned this issue Feb 3, 2020
Merged
27 tasks
greatislander pushed a commit that referenced this issue Feb 10, 2020
@jhung
feat: refactor buttons and links using custom properties (#229)
245c866 
- Resolves #188.
- Resolves #189.
- Resolves #201.
- Resolves #202.
- Resolves #204.
- Resolves #208.
- Resolves #219.
- Resolves #221.
- Resolves #222.
- Resolves #223.
- Resolves #231.

Co-authored-by: jhung <jhung@ocadu.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor buttons and links using custom properties platform-coop-toolkit/pinecone
1 participant
@cherylhjli