Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing between link lists & accordions #223

Closed
cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Closed

Spacing between link lists & accordions #223

cherylhjli opened this issue Jan 31, 2020 · 0 comments · Fixed by #229
Assignees
@greatislander
Labels
enhancement New feature or request
Projects
Pinecone 1.0.0 Cooperative Resource Library 1.0.0
Milestone
1.0.0-alpha.10

Comments

@cherylhjli
Copy link

Is your feature request related to a problem? Please describe.

Currently the focus states are running into each other.

Describe the solution you'd like

See below, left is current and right is proposed. The vertical height between the lines go from 44 to 54. Even though it inevitably still runs into other components due to just the nature of the line being on the outside, now it's a little less imposing (hopefully).
Screen Shot 2020-01-31 at 2 12 05 PM
@cherylhjli cherylhjli added the enhancement New feature or request label Jan 31, 2020
@greatislander greatislander mentioned this issue Feb 3, 2020
Merged
27 tasks
@greatislander greatislander self-assigned this Feb 4, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 4, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Feb 4, 2020
@greatislander greatislander moved this from To do to Review in progress in Pinecone 1.0.0 Feb 4, 2020
@greatislander greatislander moved this from Review in progress to In progress in Pinecone 1.0.0 Feb 4, 2020
@greatislander greatislander moved this from To do to In progress in Cooperative Resource Library 1.0.0 Feb 4, 2020
@greatislander greatislander added this to the 1.0.0-alpha.10 milestone Feb 4, 2020
Cooperative Resource Library 1.0.0 automation moved this from In progress to Done Feb 10, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Feb 10, 2020
greatislander pushed a commit that referenced this issue Feb 10, 2020
@jhung
feat: refactor buttons and links using custom properties (#229)
245c866 
- Resolves #188.
- Resolves #189.
- Resolves #201.
- Resolves #202.
- Resolves #204.
- Resolves #208.
- Resolves #219.
- Resolves #221.
- Resolves #222.
- Resolves #223.
- Resolves #231.

Co-authored-by: jhung <jhung@ocadu.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.10
Development

Successfully merging a pull request may close this issue.

feat: refactor buttons and links using custom properties platform-coop-toolkit/pinecone
2 participants
@greatislander @cherylhjli