Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible notifications with fixed tab order and floating on scroll #241

Closed
jhung opened this issue Feb 12, 2020 · 0 comments · Fixed by #242
Closed

Accessible notifications with fixed tab order and floating on scroll #241

jhung opened this issue Feb 12, 2020 · 0 comments · Fixed by #242
Assignees
Labels
enhancement New feature or request

Comments

@jhung
Copy link
Contributor

jhung commented Feb 12, 2020

Is your feature request related to a problem?

Notifications need to be implemented in a way that is accessible and useful. If notifications appear at the top of the page, then it may not be visible if the view port is scrolled. Another implementation is to use a floating or fixed position notification so it's always visible on screen, but this may cause confusion with the tab order.

Describe the solution you'd like

A possible solution is to use a hybrid approach where a notification appears in a pre-determined area in the page (i.e. at the top of the document) and therefore appear in the standard document tab order and accessible in a predictable way.

If the user's viewport has the notification off-screen, then the notification will "float" visually (using CSS) so it isn't missed, but the notification remains in the original location in the DOM.

The tab order for the notification (close button) focusing the notification will bring focus back to the top of the page where the notification resides (even though it may have been floating because the viewport scrolled).

The actual implementation can vary as long as an accessible notification resides in a predictable location in the document.

@jhung jhung added the enhancement New feature or request label Feb 12, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Feb 12, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 12, 2020
@greatislander greatislander self-assigned this Feb 12, 2020
greatislander added a commit that referenced this issue Feb 13, 2020
Add align-right and align-left classes
Make notifications sticky (resolves #241)
Add destructive borderless button variant
Pinecone 1.0.0 automation moved this from To do to Done Feb 13, 2020
greatislander pushed a commit that referenced this issue Feb 13, 2020
* feat: add component and styles for favorites page (resolves #205)
* feat: add align-right and align-left classes
* feat: make notifications sticky (resolves #241)
* feat: add destructive borderless button variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants