feat: add component and styling for favorites page #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
moved this from To do
to In progress
in Cooperative Resource Library 1.0.0
|
Deploy preview for pinecone ready! Built with commit 483bba4 |
|
Looks great! |
Add align-right and align-left classes Make notifications sticky (resolves #241) Add destructive borderless button variant
greatislander
changed the title
greatislander
added a commit
to platform-coop-toolkit/coop-library
that referenced
this pull request
Feb 13, 2020
cherylhjli
approved these changes
Feb 13, 2020
Cooperative Resource Library 1.0.0
automation
moved this from In progress
to Reviewer approved
Feb 13, 2020
greatislander
changed the title
Cooperative Resource Library 1.0.0
automation
moved this from Reviewer approved
to Done
Feb 13, 2020
greatislander
pushed a commit
to platform-coop-toolkit/coop-library
that referenced
this pull request
Feb 14, 2020
* feat: add client-side favorite management * feat: switch icon * feat: load resources via WP API on favorites page * feat: use cookies instead of localStorage to allow server-side retrieval * feat: add AJAX backend to update resource favorite counts * chore(deps): bump @platform-coop-toolkit/pinecone to 1.0.0-alpha.9 * feat: add filled favorite icon * feat: allow removal of favorites from favorites page * chore(docs): add TODO comment * feat: use new format icons * feat: check for cookies * feat: implement many changes from Pinecone * fix: add @wordpress/i18n * feat: add remove all capability * fix: remove extraneous Card initializations * feat: add notifications to favorites page * feat: add notices to single resource page * fix: menu script * fix: use new pagination markup * fix: use new pagination markup * fix: remove redundant roles to prevent duplicate announcements * feat: make notifications sticky * feat: temporary styling, prevent stacked notifications * feat: clean up styles to match platform-coop-toolkit/pinecone#242 * fix: add alert role to notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to test
Review layout: https://deploy-preview-242--pinecone.netlify.com/components/preview/favorites.html
Additional information
Not applicable.
Related issues