Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging documentation #170

Merged
merged 2 commits into from Oct 13, 2022
Merged

Logging documentation #170

merged 2 commits into from Oct 13, 2022

Conversation

marcopiraccini
Copy link
Contributor

Fixes #96

Copy link
Contributor

@simonplend simonplend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcopiraccini I've pushed up a commit with edits. Please add someone else to review these docs.

I was going to add a link to the configuration reference for core, but we don't mention the logger object there at all: https://oss.platformatic.dev/docs/reference/configuration/#core. I'll raise an issue for this.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@leorossi leorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 19ea1c6 into main Oct 13, 2022
@mcollina mcollina deleted the logging-reference branch May 15, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging documentation
4 participants