migrate sql-mapper, sql-openapi, sql-graphql to node:test #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
mateonunez
force-pushed
the
chore/migrate-sql-mapper-tests
branch
from
4bb5d84
to
f5a933e
Compare
mcollina
reviewed
Nov 25, 2023
packages/sql-mapper/test/helper.js
Outdated
| return true | ||
| } | ||
|
|
||
| module.exports.match = match |
There was a problem hiding this comment.
This is better to be put inside utils module, I suspect this would be used often.
|
(CI is failintg) |
|
This PR is still in draft as I'm trying to fix the CI. I think the test contexts are not triggering the table cleanup actions correctly. I'll spend more time on this since these tests are one of the main parts of Platformatic. |
mateonunez
force-pushed
the
chore/migrate-sql-mapper-tests
branch
from
cb3b1d6
to
3a8e447
Compare
|
Any suggestions as to why snapshot tests (sql-openapi) fail? @mcollina |
mateonunez
force-pushed
the
chore/migrate-sql-mapper-tests
branch
from
3a8e447
to
fcbfa58
Compare
|
Will try to take a look! |
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
mateonunez
force-pushed
the
chore/migrate-sql-mapper-tests
branch
from
fcbfa58
to
bc311ae
Compare
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
Hey @mcollina, sorry this PR has been in draft for a while but unfortunately I haven't had the time to devote to it yet... in the next few days I would like to pick it up again |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
Signed-off-by: mateonunez <mateonunez95@gmail.com>
mcollina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the #1796 by migrating tests from
taptonode:test.I introduced a simple helper method
match, which has the same behavior as the tap match assertion. This method is useful when you want to assert that two objects match the same structure. Unfortunately, the node match assertion only works well for regular expressions.I also created a runner file to avoid concurrency problems (this runner and others will be dropped when the
--test-concurrencyflag will be available in this CI, Node v20.10 was released right now).Migrated test
sql-mapper