test: fix runtime ci #1932
Merged
test: fix runtime ci #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
changed the title
ivan-tymoshenko
force-pushed
the
fix-runtime-ci
branch
2 times, most recently
from
4538cbd
to
f42b963
Compare
mcollina
reviewed
Dec 19, 2023
packages/runtime/lib/api.js
Outdated
| @@ -43,16 +45,25 @@ class RuntimeApi { | |||
|
|
|||
| setGlobalDispatcher(globalDispatcher) | |||
| this.#dispatcher = globalDispatcher | |||
|
|
|||
| process.on('SIGINT', async () => { | |||
There was a problem hiding this comment.
This should be moved to the top-level worker file.
| @@ -7,7 +7,7 @@ | |||
| "plt-runtime": "./runtime.mjs" | |||
| }, | |||
| "scripts": { | |||
| "test": "npm run lint && node ./test/runner.js test/cli/*.test.mjs && tsd", | |||
| "test": "npm run lint && node ./test/runner.js && tsd", | |||
packages/runtime/lib/api.js
Outdated
| parentPort.postMessage(res) | ||
|
|
||
| if (command === 'plt:stop-services') { | ||
| console.log('terminate worker thread') | ||
| process.exit() // Exit the worker thread. |
There was a problem hiding this comment.
I think this process.exit hould be moved to the top-level worker file
ivan-tymoshenko
force-pushed
the
fix-runtime-ci
branch
4 times, most recently
from
9b18886
to
272bcf8
Compare
ivan-tymoshenko
force-pushed
the
fix-runtime-ci
branch
from
272bcf8
to
d8187aa
Compare
ivan-tymoshenko
force-pushed
the
fix-runtime-ci
branch
from
9c2d2eb
to
7d91f37
Compare
mcollina
force-pushed
the
fix-runtime-ci
branch
from
0d81f95
to
43057f7
Compare
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pino@8.16.2, pino-pretty@10.2.3, tap@16.3.9 |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.