fix(client-cli): Properly interpret nullable prop #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
|
I've seen a coverage failure, but locally I get 100% 🤔 |
|
Slap a |
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
|
@mcollina not sure it's related to coverage 🤔 So I'm not sure it's related to this PR to be honest |
rozzilla
commented
Dec 19, 2023
| @@ -400,6 +400,7 @@ async function plugin (app, opts) { | |||
| client = await buildOpenAPIClient(opts, app.openTelemetry) | |||
| } else if (opts.type === 'graphql') { | |||
| if (!opts.url.endsWith('/graphql')) { | |||
| /* c8 ignore next 2 */ | |||
There was a problem hiding this comment.
FYI @mcollina probably this can be removed in another PR 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, when an Open API schema contains a
nullable: trueproperty, it's properly handled and the generated type will contain| null;