Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove spurious console.log #2021

Merged
merged 4 commits into from
Jan 26, 2024
Merged

fix: remove spurious console.log #2021

merged 4 commits into from
Jan 26, 2024

Conversation

ivan-tymoshenko
Copy link
Member

Fix: #2002

mcollina
mcollina approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not completely fix the issue.

We also want to integrate the marketplace in the future, and that log line would still be present. Those are devDependencies on purpose.

@ivan-tymoshenko
Copy link
Member Author

I see now. It looks like there was a redundant log.

@mcollina mcollina changed the title fix: move plt stackables to the deps fix: remove spurious console.log Jan 26, 2024
mcollina
mcollina approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3e20958 into main Jan 26, 2024
6 checks passed
@mcollina mcollina deleted the move-plt-stackables-to-deps branch January 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create-platformatic prints ERR_MODULE_NOT_FOUND even if everything works correctly
2 participants
@ivan-tymoshenko @mcollina