Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve parsing openapi #2024

Merged
merged 7 commits into from
Jan 30, 2024
Merged

improve parsing openapi #2024

merged 7 commits into from
Jan 30, 2024

Conversation

leorossi
Copy link
Contributor

Moved the responseWriter on its own file. All responses will be written here.

There is some duplicate code because it overlaps a little with writeContent, I'll take care of that in the future, since this part is getting a little messy

cc @rozzilla

Fixes: #1775

Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
@leorossi leorossi changed the title 1775 improve parsing openapi improve parsing openapi Jan 30, 2024
@leorossi leorossi marked this pull request as ready for review January 30, 2024 10:11
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leorossi leorossi merged commit 45ceabb into main Jan 30, 2024
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(client-cli): Error parsing OpenAPI definition
2 participants