db: add allowPrimaryKeyInInput option

[mcollina]

No description provided.

[ivan-tymoshenko]

IMO, if allowIdInInput is set to false it should generate a route schema without an id prop and here it should throw a 400 because data has an ddditional property. And if you do it programatically (with sql-mapper) it also should throw an error. Otherwise it looks like a place for a very nasty bug. wdyt?

[mcollina]

That’s how the schemas are generated. However Ajv/Fastify do not error in this case, but they rather filter the additional property.

[ivan-tymoshenko]

1. Then IMHO it should throw an error on a sql-mapper level.
2. It's easy to create a schema that would fail if some known property exist. Just set false for a property schema.

[ivan-tymoshenko]

My problem is that it would be really hard to notice the problem if you pass an id and allowPrimaryKeyInInput set to false. If you think that skipping is the best behavior it should at least log a warn message.

[mcollina]

It’s not possible to do it in sql-mapper because I’ve implemented .save() as an upsert.

[mcollina]

It's easy to create a schema that would fail if some known property exist. Just set false for a property schema.

Oh I’ll try this!

[ivan-tymoshenko]

Oh I’ll try this!

Or you can do this. Choose the error message you like more.

{
  "type": "object",
  "not": {
    "required": ["foo"]
  }
}

[mcollina]

Done with a slightly different syntax that gave a better error message.

[ivan-tymoshenko]

lgtm