feat: add logs api to the runtime management api #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Feb 19, 2024
| for (const log of message.logs) { | ||
| connection.socket.send(log) | ||
| } | ||
| }) |
There was a problem hiding this comment.
If the WebSocket goes down, you must remove the event listener. Otherwise, there will be a massive memory leak.
packages/runtime/lib/worker.js
Outdated
| loggerConfig.transport = { | ||
| target: 'pino-pretty' | ||
| } | ||
| pinoStream = pino.multistream([portStream, pinoStream]) |
There was a problem hiding this comment.
I think youàd need to set the log levels in a slightly different way. We might want to receive also trace and debug messages on the port, and filter them out on the other side.
| @@ -115,7 +117,11 @@ async function createManagementApi (configManager, runtimeApiClient) { | |||
| }) | |||
|
|
|||
| app.get('/logs', { websocket: true }, async (connection) => { | |||
There was a problem hiding this comment.
I think we should accept the log level as a querystring parameter
packages/runtime/lib/worker.js
Outdated
|
|
||
| if (loggerConfig) { | ||
| loggerConfig = { ...loggerConfig } | ||
| } else { | ||
| loggerConfig = {} | ||
| } | ||
|
|
||
| /* c8 ignore next 10 */ | ||
| let pinoStream = pino.destination(1) |
There was a problem hiding this comment.
do not instantiate to override
ivan-tymoshenko
force-pushed
the
add-runtime-logs-management-api
branch
from
fcb0070
to
68ce4d0
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.