db: fix consistency to reflect the change from migrationsTable to table #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange from migrationsTable to table 💡 refactor(schema.js): remove migrationsTable from the migrations object and add table with description and default value The `migrationsTable` property in the `PlatformaticDB` interface and the `migrationsTable` field in the `migrations` object have been renamed to `table` to improve consistency and clarity. The `table` property now represents the table created to track the schema version. The documentation and type definitions have been updated accordingly.
…ange from migrationsTable to table 💡 refactor(schema.js): remove migrationsTable from the migrations object and add table with description and default value The `migrationsTable` property in the `PlatformaticDB` interface and the `migrationsTable` field in the `migrations` object have been renamed to `table` to improve consistency and clarity. The `table` property now represents the table created to track the schema version. The documentation and type definitions have been updated accordingly. Signed-off-by: Mirko Pira <mp@mirkodev.com>
…thub.com/mirko-pira/platformatic into fix/improve-consistency-migrations-table Signed-off-by: Mirko Pira <mp@mirkodev.com>
|
Good spot! Can you fix the DCO (instructions by clicking on |
…thub.com/mirko-pira/platformatic into fix/improve-consistency-migrations-table DCO Remediation Commit for Mirko Pira <mp@mirkodev.com> I, Mirko Pira <mp@mirkodev.com>, hereby add my Signed-off-by to this commit: e611bea Signed-off-by: Mirko Pira <mp@mirkodev.com>
…thub.com/mirko-pira/platformatic into fix/improve-consistency-migrations-table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change aims to simplify and make the configuration more intuitive, eliminating ambiguity and improving property naming consistency.
📝 docs(db): update configuration.md and config.d.ts to reflect the change from migrationsTable to table
💡 refactor(schema.js): remove migrationsTable from the migrations object and add table with description and default value The
migrationsTableproperty in thePlatformaticDBinterface and themigrationsTablefield in themigrationsobject have been renamed totableto improve consistency and clarity. Thetableproperty now represents the table created to track the schema version. The documentation and type definitions have been updated accordingly.🔎 Use-case:
In scenarios prior to the update, developers configured the database migration tracking by specifying the migrationsTable property in the migration configuration object. This approach does not work. The configuration requires using the table attribute within the migrations object to define the name of the migrations table.