Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty responses with types #2172

Merged
merged 3 commits into from Feb 28, 2024
Merged

Conversation

leorossi
Copy link
Contributor

Fixes: #2138

@mcollina
Copy link
Member

control CI failure fix: #2173

Copy link
Contributor

@rozzilla rozzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on another repo, it works well! ✅

Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
@leorossi leorossi force-pushed the 2138-support-empty-response-types branch from a88201c to 5922865 Compare February 28, 2024 13:49
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leorossi leorossi merged commit 818c003 into main Feb 28, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client does not generate response types for empty responses
3 participants