New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set options.folder
when --types-only
#2253
Don't set options.folder
when --types-only
#2253
Conversation
Can you add a test? |
Closes platformatic#2251 Signed-off-by: Mikael Karon <mikael@karon.se>
e12fa03
to
506a8ab
Compare
Signed-off-by: Mikael Karon <mikael@karon.se>
I tried your branch, but the test passes also if I rollback your edit, can you please have a look? Thanks! |
Just ran the test and I get this (if I revert my change): [14:20:20.059] ERROR (70740): Command failed with exit code 2: /platformatic/node_modules/.pnpm/typescript@5.3.3/node_modules/typescript/bin/tsc --project /platformatic/packages/client-cli/test/tmp/platformatic-client-70740-1710336018054-5/tsconfig.json --rootDir .
plugin.ts(2,23): error TS2688: Cannot find type definition file for './uncanny/movies'. @leorossi Can you take another look? |
CI is failing. |
That is because the file is now generated in |
Signed-off-by: Mikael Karon <mikael@karon.se>
Signed-off-by: Mikael Karon <mikael@karon.se>
So tests are still failing because of some timeout issue, I don't think it's related to this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #2251