Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type for getHeaders #2257

Merged

Conversation

mikaelkaron
Copy link
Contributor

Fixes: #2256

Fixes: platformatic#2256

Signed-off-by: Mikael Karon <mikael@karon.se>
@mikaelkaron mikaelkaron force-pushed the mikaelkaron-client-types-getHeader-fix branch from 0a78076 to 9fd8965 Compare March 12, 2024 19:44
@mikaelkaron
Copy link
Contributor Author

I could not find any specific type tests, any suggestions on where/how to add?

@mikaelkaron mikaelkaron force-pushed the mikaelkaron-client-types-getHeader-fix branch from 9fd8965 to acd707a Compare March 12, 2024 21:35
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f749987 into platformatic:main Mar 13, 2024
87 of 89 checks passed
@mcollina mcollina requested a review from leorossi March 13, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client types for getHeaders is missing options argument
2 participants