Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Handle empty query arg #2354

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix(client): Handle empty query arg #2354

merged 2 commits into from
Apr 8, 2024

Conversation

rozzilla
Copy link
Contributor

@rozzilla rozzilla commented Apr 5, 2024 •
edited

avoid the client throwing when args.query is undefined

@rozzilla
fix(client): Handle empty query arg
a6afa6a 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla force-pushed the fix/client/handle-empty-query-arg branch from 9bc0595 to a6afa6a Compare April 5, 2024 12:59
mcollina
mcollina requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@rozzilla
Add test
b917711 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina April 5, 2024 13:36
mcollina
mcollina approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ezeheinke
ezeheinke approved these changes Apr 5, 2024
View reviewed changes
Copy link

@ezeheinke ezeheinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@leorossi leorossi merged commit dea643c into platformatic:main Apr 8, 2024
86 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@leorossi leorossi leorossi approved these changes

@ezeheinke ezeheinke ezeheinke approved these changes

@wojciechryba wojciechryba wojciechryba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rozzilla @mcollina @leorossi @ezeheinke @wojciechryba