fix(sql-mapper/types): add missing UpdateMany interface #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dating multiple entity rows in the database The 'UpdateMany' interface is added to the mapper.d.ts file to provide a way to update multiple entity rows in the database. This new interface includes options for specifying the where condition, entity fields to update, fields to be returned, and transaction participation. This enhancement allows for more flexibility and control when updating multiple entity rows in the database. Signed-off-by: Mirko Pira <mp@mirkodev.com>
mirko-pira
changed the title
|
Amazing work! Can you add a few assertions for this in https://github.com/platformatic/platformatic/blob/main/packages/sql-mapper/test/types/mapper.test-d.ts? we use tsd. |
…tests Signed-off-by: Mirko Pira <mp@mirkodev.com>
Sure, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the missing UpdateMany interface within the mapper.d.ts file, aiming to enhance the functionality of updating multiple entity rows within the database.
🔎 Use-case:
Issue: Developers attempting to update multiple entity rows simultaneously faced TypeScript errors due to the missing UpdateMany interface.
Resolution: With the UpdateMany interface now included, these TypeScript errors are eliminated. Developers can define batch update operations more naturally within the TypeScript ecosystem, improving code reliability and reducing the need for circumventing type checks.
Documentation already exists:
https://docs.platformatic.dev/docs/next/reference/sql-mapper/entities/api#updatemany