Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds pnpm-workspace.yaml when creating app with pnpm #2420

Merged
merged 1 commit into from Apr 17, 2024

Conversation

leorossi
Copy link
Contributor

Fixes: #2419
Fixes: #1094

Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
@leorossi leorossi requested a review from mcollina April 17, 2024 12:09

if (pkgManager === 'pnpm') {
execaOptions.env = {
npm_config_user_agent: 'pnpm/6.14.1 npm/? node/v16.4.2 darwin x64'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this is how we detect if the system runs pnpm or other package managers

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 918768e into main Apr 17, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pnpm-workspace.yml file when creating an app with pnpm Make create-platformatic pnpm workspace aware
2 participants