Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Do not override client params #2494

Merged
merged 1 commit into from May 2, 2024
Merged

fix(client): Do not override client params #2494

merged 1 commit into from May 2, 2024

Conversation

rozzilla
Copy link
Contributor

@rozzilla rozzilla commented May 2, 2024 •
edited

This fixes subtle bugs, since right now the client (when called), overrides the parameters passed.

As an example:

const params = {
    path: { id: 'baz' },
    query: { name: 'bar' }
  })
}
const result = await client.getPath(params)
// 馃 `params` is now { path: { id: undefined }, query: { name: undefined } } 馃

@rozzilla
fix(client): Do not override client params
4c3b1ca 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
mcollina
mcollina approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3dc2a05 into platformatic:main May 2, 2024
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rozzilla @mcollina