fix version check on create platformatic #624
Conversation
|
Can you please fix the DCO metadata? |
|
Why is failing again the DCO metadata? |
|
@malforsaja because you need to sign-off all the commits. |
|
There are instructions at https://github.com/platformatic/platformatic/pull/624/checks?check_run_id=10881670166 |
|
thank you @marcopiraccini & @mcollina, seems that last option worked to solve the DCO |
| not(supportedVersions.length, 0) | ||
| test('minimumSupportedNodeVersions', async ({ equal, not }) => { | ||
| equal(Array.isArray(minimumSupportedNodeVersions), true) | ||
| not(minimumSupportedNodeVersions.length, 0) | ||
| }) | ||
|
|
||
| test('isCurrentVersionSupported', async ({ equal }) => { |
There was a problem hiding this comment.
Can we add a test with the case that was failing? If I understand correctly, this is basically the old test (which wasn't enough to spot the problem that this PR is fixing)
There was a problem hiding this comment.
@marcopiraccini you're right, let me add another test for that case, because previous logic is that if we compare major versions if fails, i.e 16.18.0 should pass but when compared to 18.8.0 it fails because is less than last one.
…ub.com> Signed-off-by: Malfor Saja malfor.saja@gmail.com Signed-off-by: Malfor Saja <malfor.saja@gmail.com>
Signed-off-by: Malfor Saja malfor.saja@gmail.com Signed-off-by: Malfor Saja <malfor.saja@gmail.com>
* DCO Remediation Commit for Malfor Saja <malforsaja@users.noreply.github.com> Signed-off-by: Malfor Saja malfor.saja@gmail.com Signed-off-by: Malfor Saja <malfor.saja@gmail.com> * add tests for major version comparison Signed-off-by: Malfor Saja malfor.saja@gmail.com Signed-off-by: Malfor Saja <malfor.saja@gmail.com> Signed-off-by: Malfor Saja malfor.saja@gmail.com Signed-off-by: Malfor Saja <malfor.saja@gmail.com> Signed-off-by: HassanBahati <mukisabahati@gmail.com>
No description provided.