Fixed an issue when Library Dependency Finder (LDF) ignores custom "l…

…ibLDFMode" and "libCompatMode" options in `library.json`
platformio · Feb 14, 2020 · 5cc9a32 · 5cc9a32
1 parent 6556c37
commit 5cc9a32
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -13,6 +13,7 @@ PlatformIO Core 4
 * Improved support of PIO Home on card-sized PC (Raspberry Pi, etc.) (`issue #3313 <https://github.com/platformio/platformio-core/issues/3313>`_)
 * Froze "marshmallow" dependency to 2.X for Python 2 (`issue #3380 <https://github.com/platformio/platformio-core/issues/3380>`_)
 * Fixed "TypeError: unsupported operand type(s)" when system environment variable is used by project configuration parser (`issue #3377 <https://github.com/platformio/platformio-core/issues/3377>`_)
+* Fixed an issue when Library Dependency Finder (LDF) ignores custom "libLDFMode" and "libCompatMode" options in `library.json <http://docs.platformio.org/page/librarymanager/config.html>`__
 
 
 4.2.0 (2020-02-12)

diff --git a/platformio/builder/tools/piolib.py b/platformio/builder/tools/piolib.py
@@ -727,22 +727,16 @@ def lib_archive(self):
     @property
     def lib_ldf_mode(self):
         return self.validate_ldf_mode(
-            self.env.GetProjectOption(
-                "lib_ldf_mode",
-                self._manifest.get("build", {}).get(
-                    "libLDFMode", LibBuilderBase.lib_ldf_mode.fget(self)
-                ),
+            self._manifest.get("build", {}).get(
+                "libLDFMode", LibBuilderBase.lib_ldf_mode.fget(self)
             )
         )
 
     @property
     def lib_compat_mode(self):
         return self.validate_compat_mode(
-            self.env.GetProjectOption(
-                "lib_compat_mode",
-                self._manifest.get("build", {}).get(
-                    "libCompatMode", LibBuilderBase.lib_compat_mode.fget(self)
-                ),
+            self._manifest.get("build", {}).get(
+                "libCompatMode", LibBuilderBase.lib_compat_mode.fget(self)
             )
         )