Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows m57 binaries #3

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

zorn-v
Copy link

@zorn-v zorn-v commented Jun 22, 2018

Just for hint

  1. Place .npmrc in packages/platformio-ide-terminal
runtime = electron
target = 2.0.0
target_arch = x64

target_arch change to ia32 to build for x86
2. Run npm rebuild there
3. Take binaries from node_modules/pty.js/build/Release

BTW. pty.node does not builded with node v10.5.0. Just winpty.dll and winpty-agent.exe in build dir.

PS. Don't forget install VS2015 before of this 😄

@ivankravets
Copy link
Member

Thanks! 🍺

P.S: Next time please keep pty.node.bak name ;)

@zorn-v
Copy link
Author

zorn-v commented Jun 22, 2018

P.S: Next time please keep pty.node.bak name ;)

I do not understand the sense of this

@ivankravets
Copy link
Member

If we have multiple node.pty in the package, Node tries to load the first of them which will find. By default, this package includes all binaries "backuped" , the only when user starts Atom and we know node module version, we rename proper file to node.pty.

@zorn-v
Copy link
Author

zorn-v commented Jun 22, 2018

In previous AFAIR pty.node was dinamically loaded (and finded) by the package.

@zorn-v
Copy link
Author

zorn-v commented Jun 22, 2018

Node tries to load the first of them which will find

Is that confirmed or just a hunch ?

@ivankravets
Copy link
Member

This workaround was added 1 year ago when we had this issue. Please take a look at commits history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants