Update mounts to clarify "share" #408
Conversation
| @@ -345,7 +345,7 @@ The format is: | |||
| * `"/web/sites/default/files": "shared:files/files"` | |||
|
|
|||
| > **Note** | |||
| > The `shared` means that the volume is shared between your applications inside an environment. The `disk` key defines the size available for that `shared` volume. | |||
| > `shared` means that the volume is shared between builds of the same application, _not_ that the volume can be shared between different applications within a project. The `disk` key defines the size available for that `shared` volume. | |||
There was a problem hiding this comment.
The shared part doesn't mean shared between builds of the same application, it means shared between instances of the application (even though the mounts sort of are shared between builds... but that's a weird way to think about it).
We shouldn't replace one misleading statement with another. I'd suggest we remove the note entirely, and reword this section so that's it's clear mounts are persistent.
I updated the D8 example with some clearer wording recently:
https://github.com/platformsh/platformsh-example-drupal8/commit/b6c7b4f025433a66526f3dc859620446d94ae5a7#diff-fe14053ff51cb358f8b709415b2a2d17
There was a problem hiding this comment.
I agree with @pjcdawkins. We should also clarify that subfolders can be used in mounts too (ie. /foo: "shared:files/foo/bar".
There was a problem hiding this comment.
Wait sorry, subfolders can be used in mounts? Is that a new development, because that used to not be true, or so I was told.
There was a problem hiding this comment.
It's new, since 8th November
|
I'm closing this. I suspect that the "correct" wording of this feature is too subjective, so I'm going to let someone else sort it out. |
No description provided.