State the email deliverability guarantee is none #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crell
reviewed
Jan 10, 2017
| > We do not guarantee the deliverability of emails. | ||
| > It is intended as a zero-configuration, best effort service. | ||
| > Though, you may follow | ||
| > [SPF setup guidelines on SendGrid](https://sendgrid.com/docs/Glossary/spf.html) |
There was a problem hiding this comment.
Needs a "the" after "follow". Otherwise looks good.
mrkschan
force-pushed
the
mrkschan-patch-4
branch
from
3d638cb
to
2ca8350
Compare
|
Updated, the notice is merged with the paragraph for self-managed SMTP server. |
Crell
suggested changes
Jan 11, 2017
| @@ -10,12 +10,17 @@ These SendGrid sub-accounts are capped at 12k emails per month. | |||
| You can use `/usr/sbin/sendmail` on your application container to send emails | |||
| with the assigned SendGrid sub-account. | |||
|
|
|||
| Alternatively, you may use your own SMTP server. | |||
| In this case, use port 465 / 587 since port 25 is blocked for security reasons. | |||
| We do not guarantee the deliverability and support white-labeling of emails. | |||
There was a problem hiding this comment.
This sentence is clumsy. Do not guarantee delivery of what? What does white-labeling mean?
There was a problem hiding this comment.
delivery of the emails :)
regarding white-labeling, read https://sendgrid.com/docs/Classroom/Deliver/Delivery_Introduction/all_you_need_to_know_about_whitelabeling.html or https://sendgrid.com/blog/email-whitelabeling-why-its-important-and-how-sendgrid-helps/
There was a problem hiding this comment.
Do we support or don't we support whitelabeling ?
|
We do not support whitelabeling emails on PS.
…On Thu, Jan 12, 2017 at 1:26 AM, Ori Pekelman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/administration/web/email.md
<#458>:
> @@ -10,12 +10,17 @@ These SendGrid sub-accounts are capped at 12k emails per month.
You can use `/usr/sbin/sendmail` on your application container to send emails
with the assigned SendGrid sub-account.
-Alternatively, you may use your own SMTP server.
-In this case, use port 465 / 587 since port 25 is blocked for security reasons.
+We do not guarantee the deliverability and support white-labeling of emails.
Do we support or don't we support whitelabeling ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#458>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAHNg48qJFUFsJxctPgTPgDAI1Ke8-kQks5rRRCsgaJpZM4Lfko3>
.
--
[image: KS Chan on about.me]
KS Chan
about.me/mrkschan
<http://about.me/mrkschan>
|
mrkschan
force-pushed
the
mrkschan-patch-4
branch
from
2ca8350
to
7ecfe1f
Compare
Crell
approved these changes
Jan 12, 2017
pjcdawkins
reviewed
Jan 12, 2017
| We do not guarantee the deliverability of emails, and we do not support | ||
| white-labeling of them. Our SMTP proxy is intended as a zero-configuration, | ||
| best effort service. You should consider using your own SMTP server or | ||
| email delivery service provider as alternative when needed. |
|
We should also (in another PR) correct the recommended SwiftMailer config: the recommended transport should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.