Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-markdown for JavaScript code samples in documentation #176

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Apr 18, 2021

This applies our JavaScript linting to the JavaScript code samples in the markdown documentation files.

Initially, this is just focused on fixing the syntax errors and a few one-off violations. I have disabled other rules that had many violations. There are some autofixable stylistic rules we can follow-up to fix to ensure code sample formatting consistency.

…entation

This applies our JavaScript linting to the JavaScript code samples in the markdown documentation files.

Initially, this is just focused on fixing the syntax errors and a few one-off violations. I have disabled other rules that had many violations. There are some autofixable stylistic rules we can follow-up to fix to ensure code sample formatting consistency.
@coveralls
Copy link

coveralls commented Apr 18, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 18d24d6 on bmish:eslint-plugin-markdown into 8390fa7 on platinumazure:master.

Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, been meaning to do this but I keep forgetting. Looks perfect.

@platinumazure platinumazure merged commit a0f21a0 into platinumazure:master Apr 19, 2021
bmish added a commit to bmish/eslint-plugin-qunit that referenced this pull request Apr 21, 2021
* master:
  Update: Ensure boolean assertions are not missed by several rules (platinumazure#172)
  Chore: add eslint-plugin-eslint-comments (platinumazure#178)
  Docs: enable/autofix indent rule in markdown JS code samples (platinumazure#177)
  Docs: Add eslint-plugin-markdown for JavaScript code samples in documentation (platinumazure#176)
  Upgrade: Bump y18n from 4.0.0 to 4.0.1 (platinumazure#163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants