Merge pull request #56 from mingkhuang/master

fix some typos
platinummonkey · May 7, 2021 · 875d77d · 875d77d
2 parents f44c8fc + f3f7a54
commit 875d77d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/limit/aimd.go b/limit/aimd.go
@@ -22,8 +22,8 @@ type AIMDLimit struct {
 	mu sync.RWMutex
 }
 
-// NewDefaultAIMLimit will create a default AIMDLimit.
-func NewDefaultAIMLimit(
+// NewDefaultAIMDLimit will create a default AIMDLimit.
+func NewDefaultAIMDLimit(
 	name string,
 	registry core.MetricRegistry,
 	tags ...string,

diff --git a/limit/aimd_test.go b/limit/aimd_test.go
@@ -13,7 +13,7 @@ func TestAIMDLimit(t *testing.T) {
 	t.Run("DefaultAIMD", func(t2 *testing.T) {
 		t2.Parallel()
 		asrt := assert.New(t2)
-		l := NewDefaultAIMLimit("test", nil)
+		l := NewDefaultAIMDLimit("test", nil)
 		asrt.Equal(10, l.EstimatedLimit())
 	})
 

diff --git a/limit/windowed_test.go b/limit/windowed_test.go
@@ -32,7 +32,7 @@ func TestWindowedLimit(t *testing.T) {
 	t.Run("DecreaseOnDrops", func(t2 *testing.T) {
 		t2.Parallel()
 		asrt := assert.New(t2)
-		delegate := NewDefaultAIMLimit("test", nil)
+		delegate := NewDefaultAIMDLimit("test", nil)
 		minWindowTime := (time.Millisecond * 100).Nanoseconds()
 		l, err := NewWindowedLimit("test", minWindowTime, minWindowTime*2, 10, 10, delegate, nil)
 		asrt.NoError(err)
@@ -50,7 +50,7 @@ func TestWindowedLimit(t *testing.T) {
 	t.Run("IncreaseOnSuccess", func(t2 *testing.T) {
 		t2.Parallel()
 		asrt := assert.New(t2)
-		delegate := NewDefaultAIMLimit("test", nil)
+		delegate := NewDefaultAIMDLimit("test", nil)
 		minWindowTime := (time.Millisecond * 100).Nanoseconds()
 		l, err := NewWindowedLimit("test", minWindowTime, minWindowTime*2, 10, 10, delegate, nil)
 		asrt.NoError(err)

diff --git a/limiter/default.go b/limiter/default.go
@@ -16,7 +16,7 @@ import (
 const (
 	defaultMinWindowTime   = int64(1e9) // (1 s) nanoseconds
 	defaultMaxWindowTime   = int64(1e9) // (1 s) nanoseconds
-	defaultMinRTTThreshold = int64(1e5) // (100 ms) nanoseconds
+	defaultMinRTTThreshold = int64(1e5) // (100 µs) nanoseconds
 	defaultWindowSize      = int(100)   // Minimum observed samples to filter out sample windows with not enough significant samples
 )
 

diff --git a/patterns/pool/example_generic_pool_test.go b/patterns/pool/example_generic_pool_test.go
@@ -16,7 +16,7 @@ func ExamplePool() {
 	var JobKeyID = JobKey("job_id")
 
 	l := 1000 // limit to adjustable 1000 concurrent requests.
-	delegateLimit := limit.NewDefaultAIMLimit(
+	delegateLimit := limit.NewDefaultAIMDLimit(
 		"aimd_limiter",
 		nil,
 	)