Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Angular 2 Forms #55

Merged
merged 2 commits into from
Aug 22, 2016
Merged

Add support for new Angular 2 Forms #55

merged 2 commits into from
Aug 22, 2016

Conversation

platosha
Copy link
Owner

@platosha platosha commented Aug 8, 2016

Fixes #43


This change is Reviewable

@tehapo
Copy link
Contributor

tehapo commented Aug 15, 2016

Looks like this PR does not compile anymore against Angular 2.0.0-rc.5 version.

src/polymer-element.spec.ts(2,1): error TS2305: Module '"[clip]@angular/core/testing"' has no exported member 'describe'.
src/polymer-element.spec.ts(3,1): error TS2305: Module '"[clip]@angular/core/testing"' has no exported member 'expect'.
src/polymer-element.spec.ts(4,1): error TS2305: Module '"[clip]@angular/core/testing"' has no exported member 'it'.
src/polymer-element.spec.ts(10,10): error TS2305: Module '"[clip]@angular/compiler/testing"' has no exported member 'TestComponentBuilder'.
src/polymer-element.spec.ts(10,32): error TS2305: Module '"[clip]@angular/compiler/testing"' has no exported member 'ComponentFixture'.
src/polymer-element.spec.ts(207,11): error TS2346: Supplied parameters do not match any signature of call target.

I can take a look at this and add a commit to fix this.

@tehapo tehapo self-assigned this Aug 15, 2016
@tehapo tehapo force-pushed the feature/new-forms-api branch 4 times, most recently from 8330595 to 71e6ffb Compare August 17, 2016 12:29
@manolo
Copy link
Contributor

manolo commented Aug 22, 2016

:lgtm:


Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@manolo manolo merged commit b121516 into master Aug 22, 2016
@manolo manolo deleted the feature/new-forms-api branch August 22, 2016 09:45
@manolo manolo removed the in review label Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants