Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds //iteminfo command #115

Merged
merged 18 commits into from
May 24, 2024
Merged

Adds //iteminfo command #115

merged 18 commits into from
May 24, 2024

Conversation

elftausend
Copy link

Adds iteminfo command as described in #30

@platz1de
Copy link
Owner

Information about defence or max durability don't really fit the scope of a world-editor, there are other plugins to do that
I don't see much point in an iteminfo command other than debugging (printing formatted nbt for bedrock & java equivalent)

@platz1de platz1de closed this Mar 30, 2024
@elftausend
Copy link
Author

Makes sense. I could remove the unrelated info and implement printing the nbt data, if that's okay.
Anyways, could you please either close #30 or update the labels, scope, etc?

@platz1de
Copy link
Owner

The issue is still relevant and will be implemented with the exception of max durability, so no reason to change anything about it

About this pr then:
To be consistent with block info, the default message format should be for example:
{count}x {name} ({id}:{meta})\nItem data: {nbt}\nJava data: {java_nbt}
for the id, the stringy id is more useful (runtime ids are only displayed for legacy purposes) and can be directly gathered from the item serializers (or just extract it from the nbt)

Here's an example of how the data command of java edition renders nbt
grafik

@platz1de platz1de reopened this Mar 30, 2024
resources/lang/eng.yml Outdated Show resolved Hide resolved
resources/lang/eng.yml Show resolved Hide resolved
src/platz1de/EasyEdit/convert/ItemConvertor.php Outdated Show resolved Hide resolved
src/platz1de/EasyEdit/convert/ItemConvertor.php Outdated Show resolved Hide resolved
src/platz1de/EasyEdit/convert/ItemConvertor.php Outdated Show resolved Hide resolved
src/platz1de/EasyEdit/convert/ItemConvertor.php Outdated Show resolved Hide resolved
src/platz1de/EasyEdit/utils/ItemInfoUtil.php Outdated Show resolved Hide resolved
src/platz1de/EasyEdit/utils/ItemInfoUtil.php Show resolved Hide resolved
@platz1de platz1de merged commit 400e4ba into platz1de:dev May 24, 2024
1 of 2 checks passed
@platz1de
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants