Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Numeric IDs migration #2762

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Mar 16, 2023

Changes

First pass on Numeric IDs Clickhouse migration.
For now the PR contains the necessary SQL files + a coordination script.
I expect things to change going forward, but submitting this as an interim PR - no action required yet, should be completely transparent.

I am trying to work on an integration test on the side but it's currently painful due to clickhouse container having to call the host in order to retrieve domains lookup dictionary via HTTP. Awaiting clarity on clickhouse-postgres connectivity for that.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol aerosol requested review from cnkk and ukutaht March 16, 2023 09:06
@bundlemon
Copy link

bundlemon bot commented Mar 16, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
298.84KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
733B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aerosol aerosol force-pushed the numeric-ids-migration-control-module branch from 83486ca to 06f22bc Compare March 21, 2023 09:19
@aerosol
Copy link
Member Author

aerosol commented Mar 21, 2023

Rebased & adjusted for #2733

Copy link
Contributor

@vinibrsl vinibrsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Awesome work, @aerosol.

lib/plausible/data_migration/numeric_ids.ex Outdated Show resolved Hide resolved
aerosol and others added 3 commits March 22, 2023 13:01
* Add regular ecto migration

* Fix typo

* Update priv/ingest_repo/migrations/20230320094327_create_v2_schemas.exs

Co-authored-by: Vini Brasil <vini@hey.com>

* Implement v2 events/sessions schema modules (#2777)

* Implement v2 events/sessions schema modules

* Clean up session schemas

---------

Co-authored-by: Vini Brasil <vini@hey.com>
@aerosol aerosol merged commit 6637751 into master Mar 23, 2023
@aerosol aerosol deleted the numeric-ids-migration-control-module branch March 23, 2023 08:47
@aerosol aerosol mentioned this pull request Mar 29, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants